Profiling tool : Profiling tool throws NPE when appInfo is null and unchecked #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthosa
requested changes
Oct 30, 2023
core/src/main/scala/com/nvidia/spark/rapids/tool/profiling/CollectInformation.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/com/nvidia/spark/rapids/tool/profiling/CollectInformation.scala
Outdated
Show resolved
Hide resolved
| @@ -390,7 +390,9 @@ class Analysis(apps: Seq[ApplicationInfo]) { | |||
| val allRows = apps.flatMap { app => | |||
| app.sqlIdToInfo.map { case (sqlId, sqlCase) => | |||
| SQLDurationExecutorTimeProfileResult(app.index, app.appId, sqlId, sqlCase.duration, | |||
| sqlCase.hasDatasetOrRDD, app.appInfo.duration, sqlCase.problematic, | |||
| sqlCase.hasDatasetOrRDD, | |||
| if (app.appInfo != null) app.appInfo.duration else Option(0L), | |||
There was a problem hiding this comment.
nit: Can we use option and map instead of if else in arguments to make it more idiomatic?
There was a problem hiding this comment.
Is this the latest version? I see "Addressed" but the code is still using if-else-then?
Signed-off-by: Kuhu Shukla <[email protected]>
kuhushukla
force-pushed
the
npe_profile
branch
from
60f48c5 to
1b2cc31
Compare
|
Please take a look @cindyyuanjiang , @parthosa |
|
Added headers for 2024 🎈 |
|
kuhushukla
force-pushed
the
npe_profile
branch
from
1b2cc31 to
3aa9808
Compare
Signed-off-by: Kuhu Shukla <[email protected]>
kuhushukla
force-pushed
the
npe_profile
branch
from
3aa9808 to
2ebba77
Compare
|
Ok, we should be good now @cindyyuanjiang , @amahussein , apologies- my commit from yesterday ended with a bad push. |
amahussein
added
core_tools
amahussein
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #639 , needs a test , therefore draft